Skip to content

fix: transfer drag and drop styles - #1769

Merged
cooper-joe merged 1 commit into
LIBS-764/transfer-items-drag-and-dropfrom
jc/libs-764
Sep 24, 2026
Merged

cooper-joe merged 1 commit into
LIBS-764/transfer-items-drag-and-dropfrom
jc/libs-764

Conversation

@cooper-joe

Copy link
Copy Markdown
Member

Description

This PR adjusts the styles of the incoming Transfer drag and drop functionality:

  • Does not show list container highlight when reordering, the "container outline" is only shown when moving from one list to another.
  • Shows an insertion line at the end of the list when reordering.
  • Use neutral grey for the interaction cues, remove background tint, use an outline overlaid on the panel border to avoid the "blurry double border".
  • Slight transparency on the drag preview.

Checklist

  • API docs are generated
  • Tests were added
  • Storybook demos were added

All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.


Screenshots

image image

@cooper-joe
cooper-joe requested a review from a team as a code owner September 24, 2026 07:36
@cooper-joe
cooper-joe requested review from arina-gutuboe and removed request for a team September 24, 2026 07:36
@sonarqubecloud

Copy link
Copy Markdown

@dhis2-bot

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://pr-1769--dhis2-ui.netlify.app

@dhis2-bot
dhis2-bot temporarily deployed to netlify September 24, 2026 07:39 Inactive

@arina-gutuboe arina-gutuboe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

@cooper-joe
cooper-joe merged commit fb60f11 into LIBS-764/transfer-items-drag-and-drop Sep 24, 2026
19 checks passed
@cooper-joe
cooper-joe deleted the jc/libs-764 branch September 24, 2026 08:29

This branch was previously deployed

1 inactive deployment
netlify — 76834b75 Deployed Sep 24, 2026 by dhis2-bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants