Choose the shorter quote style for string literals - #151
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
repr() only switches to double quotes when a string contains a single quote and no double quote. A string containing both, with more single quotes than double quotes, was therefore rendered with every single quote escaped, which could make the output longer than the input. Try the double quoted form as well and keep whichever is shorter, still preferring single quotes on a tie. Fixes dflook#150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150
repr()only switches to double quotes when a string contains a single quote and no double quote, so a string with more single quotes than double quotes gets every single quote escaped — which can make the minified output longer than the input (print("'\"'")is 13 bytes in, 14 bytes out).stringliteralnow also builds the double quoted form and keeps whichever is shorter, still preferring single quotes on a tie so existing output is unchanged everywhere else.Regression tests cover all four cases from the issue; the last one fails without the fix. Round-trip checked over 200k random strings built from quotes, backslashes, newlines and non-ASCII, and the full suite passes (676 passed, 59 skipped).
This change was prepared with AI assistance; the regression test was run locally and fails without the fix.