fix: throw an error instead of ignoring it when uploading batches - #207
Open
gasperzgonec wants to merge 12 commits into
Open
fix: throw an error instead of ignoring it when uploading batches#207gasperzgonec wants to merge 12 commits into
gasperzgonec wants to merge 12 commits into
Conversation
gasperzgonec
commented
Jun 8, 2026
gasperzgonec
commented
Jun 8, 2026
gasperzgonec
commented
Jun 8, 2026
radovanjorgic
changed the title
gasperzgonec
force-pushed
the
gasperz/ASCPT-28
branch
from
June 11, 2026 07:50
27ba842 to
7a4fc6e
Compare
|
|
|
- Revert defensive logFn guard in spawn.ts (unrelated to this fix, logFn is always a function on the real Logger). - Rename canEmit to prepared and document beforeEmit's return contract. - Collapse sendToPlatform/afterEmit into a single emitToPlatform method, matching the beforeEmit/buildEmitPayload/afterEmit shape used in v2. - Inline emitUploadFailure into beforeEmit's catch block since it had a single call site. - Run eslint --fix to clean up pre-existing formatting violations.
|
Matches v2's adapter shape (beforeEmit/buildEmitPayload/afterEmit, no separate sendToPlatform/emitToPlatform helper) per review feedback. beforeEmit no longer swallows the repo-upload failure itself; emit() catches it, collects partial artifacts, and picks the error event type before sending, so there's a single call site for the actual platform emit and its WorkerMessageEmitted/WorkerMessageExit outcome handling.
|
radovanjorgic
marked this pull request as draft
July 22, 2026 08:52
# Conflicts: # src/multithreading/worker-adapter/worker-adapter.ts
gasperzgonec
marked this pull request as ready for review
August 10, 2026 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Connected Issues
Checklist
npm run testOR no tests needed.npm run test:backwards-compatibility.npm run lint.