Repository navigation
fix: voice activity hangover overflow and rounding - #503
Merged
Merged
Conversation
devopvoid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voice activity hangovers at
Integer.MAX_VALUEmilliseconds overflowed when native code added 9 before rounding to 10 ms chunks. Sub-millisecond portions were also truncated in bothAudioTrackandPeerConnectionFactory, so 10.5 ms incorrectly became a 10 ms hangover instead of 20 ms.Round partial milliseconds up in Java and use quotient/remainder rounding in native code, preserving the existing JNI signature. Add regression coverage for both listener paths at zero, 1 ns, exact 10/20 ms boundaries, 10 ms + 1 ns, 10.5 ms, the maximum accepted duration, and rejection just above that maximum.
The JNI library was rebuilt using the existing build configuration. The audio suite passed with 109 tests passing and 1 skipped. A full Maven verify was blocked during WebRTC configuration by filesystem restrictions; an additional full module test run encountered a peer-connection timeout and was stopped after stalling in video tests.