Repository navigation
fix: restart PulseAudio after the last peer connection closes - #501
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the last peer connection terminates the factory's audio device module. When another peer reuses the module, PulseAudio starts new processing threads with
quit_still set, so both playout and recording fail to start after a ten-second wait.Reset
quit_under the existing mutex before spawning either thread. Apply this as a required Linux WebRTC patch, preserve LF line endings for Linux patches, and fail the build if the fix cannot be applied. Add opt-in PulseAudio integration coverage for five consecutive playout, recording, and receive-only SDP negotiation cycles with a reused factory and module (-Dwebrtc.test.pulseaudio=true).Fixes #500.