Repository navigation
fix: bound HTTP response reads and handle overflowing retry dates - #499
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP requests could remain pending indefinitely when a server stopped sending data after the response headers. Enforce an independent deadline across the entire request, including response bodies and retries, and cancel the deadline when the request completes.
Treat out-of-range Retry-After dates as invalid and propagate response-processing failures to the caller, so an overflowing date cannot leave the result future unresolved. Add regression coverage for stalled bodies and overflowing retry dates.