Repository navigation
feat: seek to the keyframe before a position with fastSeek - #497
Merged
Merged
Conversation
MediaPlayer.fastSeek and MediaFileSource.fastSeek play from the keyframe at or before the position, without decoding up to it, so they take no longer however far the keyframes are apart, as a slider being dragged needs.
Keeps the seek further back of #496 for precise seeks only: a fast seek plays from the keyframe the reader lands on.
A seek whose first picture came only when the decoder was drained at the end left its late landing behind, and a looping source took it on the next pass, sending the reader back to the end again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds MediaPlayer.fastSeek and MediaFileSource.fastSeek, which play from the keyframe at or before the position without decoding up to it, so they take no longer however far the keyframes are apart, as a slider being dragged needs; seek stays precise. Touches PerformSeek like the MPEG-TS seek fix, so whichever lands second needs a small rebase.