Repository navigation
fix: compute bitrates over report times, report stats handler errors - #449
Merged
Merged
Conversation
Bitrates used the time a report was read rather than measured, so reports delayed on a busy control executor gave rates far too high. They now use the report timestamp, repeat the bitrates of a cached report, and give -1 after the clock went back or a counter started again. PeerStats.timestamp() is the report time. A throwing onStats handler now reaches the error handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitrates used the time a report was read instead of measured, so reports delayed on a busy control executor gave rates far too high. They now use the report timestamp: a cached report repeats its bitrates, a clock that went back or a counter that started again gives -1.
PeerStats.timestamp()is the report time.A throwing
onStatshandler now reaches the error handler, and later samples still arrive.