Repository navigation
fix: close a media player from a sink of a track it feeds - #435
Merged
Merged
Conversation
A sink runs on the player's pacing thread, so close() from there joined that thread and aborted the JVM. The native release now detects the player's own threads and destroys the player on another one. MediaFileSource.close() no longer holds a lock while waiting for the player, which deadlocked against a close from a listener or sink.
devopvoid
force-pushed
the
fix/close-player-from-sink
branch
from
October 24, 2026 12:42
a141320 to
185058d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sink of a track fed by a
MediaPlayerruns on the player's pacing thread, so callingclose()there joined that thread and aborted the JVM. The native release now detects the player's own threads and destroys the player on another thread once the call has returned.MediaFileSource.close()no longer holds a lock while waiting for the player, which deadlocked against a close from a listener or sink.