Repository navigation
fix: run queued peer operations after the runtime stopped its timer - #431
Merged
Merged
Conversation
A closing runtime stops its timer while control tasks queued before still run. An operation reaching a peer then still scheduled its timeout, even when the closed peer had failed it already, and the rejection went to the error handler, which made HttpSessionTests.lateAnswerDeleted fail now and then. Operations that are done need no timeout, and the operation, gathering and collision timers are skipped once the timer rejects.
…tion-timer # Conflicts: # webrtc/src/test/java/dev/onvoid/webrtc/client/RuntimeCloseTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A closing runtime stops its timer while control tasks queued before still run. An operation that reached a peer then still scheduled its timeout, even when the closed peer had already failed it, and the rejection went to the error handler. This made
HttpSessionTests.lateAnswerDeletedfail now and then on macOS.