Repository navigation
fix: wide planar audio, audio timestamp gaps and vanished audio devices - #428
Merged
Merged
Conversation
A descriptor the module no longer lists selected device 0, so an unplugged microphone was silently replaced by another one. Modules that name no devices (Linux) keep using their default.
swr_convert got frame->data, which holds eight planes, so planar audio of more channels read past it and crashed. Audio timestamps now drive the output: gaps are filled with silence and overlaps skipped, so audio no longer drifts ahead of video after missing audio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AudioDecoderreads input planes fromextended_data; planar audio with more than eight channels read pastframe->dataand crashed in swresample.setPlayoutDevice/setRecordingDevicethrowIllegalArgumentExceptionfor a device the module no longer lists instead of selecting device 0;Devices.useMicrophone/useSpeakerpass that on without the stop-and-retry. Modules that name no devices (Linux) keep using their default.