Repository navigation
fix: size YUY2, UYVY and NV12 frames of odd width in whole pixel pairs - #422
Merged
Merged
Conversation
YUY2 and UYVY rows, and NV12 and NV21 chroma rows, end with a whole pair, so a frame of odd width was written past the buffer it was checked against, and written with other strides than it is read with. Sizes are now computed in 64 bits, and empty or oversized frames and unknown formats are rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YUY2 and UYVY rows, and NV12 and NV21 chroma rows, always end with a whole pixel pair. With an odd width,
CalcBufferSizeundercounted YUY2/UYVY frames, so a conversion wrote (or read) past the checked buffer, andConvertFromI420wrote these formats with other strides thanConvertToI420reads them with.ConvertToI420.INT_MAX / 4and unknown formats are rejected.