Convert file data strings to actual files - #194
Merged
devmount merged 1 commit intoSep 17, 2026
Merged
Conversation
devmount
deleted the
enhancements/193-file-uploads-for-log-and-asignature
branch
September 17, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Converts the
logoandsignaturesettings from a plain text cell holding a pasteddata:image/...;base64,...string into proper Filament image uploads.logo/signaturesettings are now marked with a newtype = 'image'localdisk undersettings/;Setting::valuenow holds the relative file path instead of a base64 string.Settingdeletes the previous file automatically whenever an image setting's value is replaced or cleared.Benefits
Notes for reviewers / deploy
logo/signaturewill appear empty until re-uploaded once through the new UI — this was a deliberate choice to avoid a one-way, unreviewable data migration.PdfTemplatehandles the gap gracefully (PDFs generate without a logo/signature in the meantime).Applicable Issues
Closes #193