Skip to content

Convert file data strings to actual files - #194

Merged
devmount merged 1 commit into
mainfrom
enhancements/193-file-uploads-for-log-and-asignature
Sep 17, 2026
Merged

devmount merged 1 commit into
mainfrom
enhancements/193-file-uploads-for-log-and-asignature

Conversation

@devmount

Copy link
Copy Markdown
Owner

Description of the Change

Converts the logo and signature settings from a plain text cell holding a pasted data:image/...;base64,... string into proper Filament image uploads.

  • logo/signature settings are now marked with a new type = 'image'
  • In the settings table, those two rows now show an image thumbnail (or a "click to upload" hint when empty)
  • Uploaded files are stored on the local disk under settings/; Setting::value now holds the relative file path instead of a base64 string. Setting deletes the previous file automatically whenever an image setting's value is replaced or cleared.
  • The logo and signature are now scaled by height only, with width following the uploaded image's own aspect ratio, instead of a hardcoded width/height box.

Benefits

  • No more manually pasting a huge base64 string into a single-line text field.
  • Upload, replace, and delete are now explicit, discoverable actions with a live preview, instead of an implicit side effect of editing raw text.
  • Non-square logos are no longer squashed into a fixed box.

Notes for reviewers / deploy

  • Existing base64 values are not auto-converted. After this deploys, logo/signature will appear empty until re-uploaded once through the new UI — this was a deliberate choice to avoid a one-way, unreviewable data migration. PdfTemplate handles the gap gracefully (PDFs generate without a logo/signature in the meantime).
  • Because logo width is no longer capped, a very wide/landscape logo could now visually run into the title text in the PDF header. Best to upload a roughly square logo.

Applicable Issues

Closes #193

@devmount devmount self-assigned this Sep 17, 2026

@devmount devmount left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devmount
devmount merged commit ca0bbdd into main Sep 17, 2026
2 checks passed
@devmount
devmount deleted the enhancements/193-file-uploads-for-log-and-asignature branch September 17, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert logo and signature to actual file upload fileds

1 participant