Fix finance and tax calculations - #190
Merged
Merged
Conversation
devmount
changed the title
devmount
marked this pull request as ready for review
September 11, 2026 08:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes a series of calculation and rounding bugs found during an audit of every place the app computes or displays money and tax figures: pass-through invoices leaking into tax filings, VAT dropped for Rent/Utility expenses, an inverted formula for project-priced invoice positions, an off-by-one GWG threshold, and chart double-counting on period boundaries. Each fix is covered by a regression test that failed before and passes after.
Benefits
Tax return figures, invoice totals, and dashboard numbers can now be trusted to be accurate, with regression tests in place to catch any of these calculations breaking again.
Applicable Issues
Closes #189