Repository navigation
docs: refresh demo participation after execution-window repair - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The execution-window repair in #7 excludes post-window markout events from participation volume. The deterministic CLI demo therefore now reports 2.198% for all eight policy/style rows, while the README still displayed 1.888%.
Refresh those eight values from an actual run of
python -m tradeforge.interfaces.cli demoand explain that participation includes only market volume observed inside the parent execution window. All other displayed demo values remain identical. Only README text changes.Validation: all six normalized-CSV execution-window regressions passed independently and the complete deterministic CLI demo ran successfully. All six checks on this PR's final head passed: https://github.com/dev-belly/TradeForge/actions/runs/37738997953 . After merging as
689d255d818d95facacc514d36959288f31fd673, all six main checks also passed: https://github.com/dev-belly/TradeForge/actions/runs/37739802938 . These cover Python 3.11–3.13, lint/format/types, architecture/leakage checks, native unit/differential tests, ASan/UBSan and deterministic replay.