Repository navigation
fix: ship default configuration and SQL with installed TradeForge - #16
Merged
Merged
Conversation
dev-belly
marked this pull request as ready for review
October 18, 2026 14:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An installed TradeForge wheel fails outside its source checkout: doctor cannot find configs/, and db list cannot find sql/. Include all 10 YAML defaults and seven analytical queries in the Python package. Resolve omitted defaults at call time, preferring an existing working-directory configs/ or sql/ directory, then the bundled resources. Explicit --configs/--sql-dir paths remain strict. Update CLI, API and dashboard default lookups without changing execution or matching rules.
Add regressions for import-then-chdir, newly created local overrides, incomplete local configuration, strict missing explicit paths, and byte equality between packaged and editable defaults. Add a distribution check that builds through an sdist, verifies every resource in the wheel, installs into a clean virtual environment, clears source import paths, and runs doctor, the synthetic demo and SQL listing outside the checkout. CI executes this path on Linux and Windows Python 3.12.
Validation: reproduced both failures with the original installed wheel. Ten new regressions passed; all 11 changed Python files passed lint and formatting checks. Rebuilt sdist/wheel resources match the source bytes exactly. A regular fixed-wheel installation outside the checkout ran doctor, all seven query listings, and four policies × two styles with the documented demo results. The local wheel test used existing/cached runtime dependencies (--no-deps). All eight PR CI jobs subsequently passed: clean installed-wheel checks on Linux and Windows, Python 3.11/3.12/3.13 tests and type/lint checks, C++ differential tests, ASan/UBSan and reproducibility.
Windows installation checks exercise the Python reference backend; native C++ build and differential checks remain on Linux.