Repository navigation
fix(vue): preserve native Once cancellation before core handlers - #171
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
elonehoo
marked this pull request as ready for review
November 6, 2026 09:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.once.preventcan veto the first event without suppressing later core events.useNativeEventPropsadapter and a tested SFC example for explicitly cooperating DOM-forwarding wrappers.Validation
Scope
Arbitrary custom components are not automatically treated as DOM receivers. The explicit adapter example documents native Once lifetime and limitations. No release or merge requested.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Note
Medium Risk
Rewrites Vue listener merging and ordering for Once vs core across factory, Dynamic, and Steps/Select; behavior change is security-adjacent (event handling) but heavily test-covered.
Overview
Release and docs: Bumps root and all public packages to 0.0.4, adds 0.0.4 release notes and
vue-once-listeners.md, updates release-scope andchangelogithub.config.mjsfor the new fix-section copy, and pointsscripts/test-release-notes.mjsat 0.0.3→0.0.4 expectations.Vue behavior: Introduces
useCoreListenerProps(shared by Steps/Select trigger composables) pluscore-listenersutilities that reorder nativeOncelisteners before core handlers where core is composed, track known core functions, and thread__uiComposeOncethroughDynamicand theasChildfactory so merged props stay correct.Public API: Exports
useNativeEventPropsfor custom DOM-forwarding components to bind attrs at the real native element.Tests: Large additions and updates for Steps/Select listener contracts, once boundaries, SSR/hydration, and browser trusted click/keydown cases.
Risk: Medium — core change to how Vue merges and runs event listeners for Steps/Select and
asChild; mitigated by broad new tests but worth careful review for edge cases.Reviewed by Cursor Bugbot for commit 167f224. Bugbot is set up for automated code reviews on this repo. Configure here.