docs: fix 18 typos in comments and documentation - #24
Open
Avicennasis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 18 typos in comments, Javadoc and one error message across 7 sample activities. All are in
app/src/main/java/com/deezer/sdk/sample/.unnecesary->unnecessary(comment// disable unnecesary buttons)splitted by genre->split by genre(Javadoc)Unparsed reponse->Unparsed response(message passed tonew DeezerError(...))stray
ofin Javadoc —The list of <x> of displayed by this activity.->The list of <x> displayed by this activity.(
UserRadiosActivityL43 andRadiosActivityL38 already read correctly, which is what confirms the stray word.)Notes for reviewers
Unparsed reponse->Unparsed responsefix changes the message text of aDeezerError. It is a sample-app error message, there are no test sources in this repository and nothing asserts on the string, but please review that hunk specifically.RadiosActivity,UserAlbumsActivity,UserArtistsActivity,UserRadiosActivity,UserTopTracksActivity) keep their CRLF endings;EqualizerActivityandVisualizerActivitykeep LF. The diff is 18 changed lines and nothing else.unnecesary/Unparsed reponse/splittedstrings also occur inUserFlowActivity.java,UserCustomTrackListActivity.java,UserPlaylistsActivity.javaandHomeActivity.java. Those were outside the scope of this pass and are left untouched — happy to extend the PR to cover them if you would prefer a single sweep.No functional changes - comments, Javadoc and one error-message string only.