Repository navigation
suunto_nautic: public paged fetch for any resource - #12
Merged
Merged
Conversation
suunto_nautic_device_fetch_paged runs the GET -> paged 0x0D -> release sequence the /Summary download uses, for any path, so a multi-page resource such as /Logbook/byId/<id>/Descriptors (about 97 pages) reaches the MAX_PAGES cap instead of stopping at the first frame. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
latishab
added a commit
to deepsealabs/libdc-swift
that referenced
this pull request
Oct 12, 2026
… through whole MAX_PAGES was raised to 512 for /Logbook/byId/<id>/Descriptors, but only the /Summary download used the paged read, so fetch/fetchRaw still stopped at the first frame (476 of 43,140 bytes). - SuuntoNauticExplorer.fetchPaged(device:path:) over the new suunto_nautic_device_fetch_paged (deepsealabs/libdivecomputer#12) - DC Tester's Explorer pages Descriptors as well as /Summary - fake watch serves a paged Descriptors schema; a 96-page one comes back whole Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
suunto_nautic_device_fetch_paged(device, path, buffer): the GET -> paged 0x0D -> release sequence/Summaryalready uses, for any path./Logbook/byId/<id>/Descriptorsis about 97 pages, so until now the raisedMAX_PAGES(512) was unreachable for it (deepsealabs/libdc-swift#72).Tested from libdc-swift with a fake watch serving a 43,140-byte Descriptors schema (96 pages); the whole schema comes back.
🤖 Generated with Claude Code