fix: preserve explicit API key semantics - #778
Open
GregHolmes wants to merge 1 commit into
Open
Conversation
GregHolmes
requested review from
deepgram-kiley and
dg-coreylweathers
as code owners
September 1, 2026 16:12
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEEPGRAM_API_KEYat construction only when theapi_keyargument is omittedapi_key=Nonerejects authentication instead of silently using an ambient process credentialDEEPGRAM_API_KEYNonebehaviorFollow-up to #767 and #734.
Why
#767 correctly fixed delayed environment loading, but its
kwargs.get("api_key") is Nonecheck treated an omitted argument and explicitNoneas equivalent. In tests, multi-tenant services, or applications intentionally suppressing ambient authentication, explicitNonemust not activate a process-wide credential.Verification
1020 passed, 1 skippedmypy src: clean across 901 source filesgit diff --check: clean