[snapshot] fix deprecated VS-connector subresources group - #448
Merged
Conversation
Switched VS-connector subresources from subresources.snapshot.storage.k8s.io to subresources.storage-foundation.deckhouse.io. Signed-off-by: Konstantin Kozoriz <konstantin.kozoriz@flant.com>
AleksZimin
approved these changes
Aug 20, 2026
ldmonster
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VolumeSnapshot node subresources (manifests-download, manifests-with-data-restoration, manifests-and-children-refs-upload) are now served by storage-foundation, not state-snapshotter. d8 was still addressing the old group, which now works only as a server-side deprecated alias.
Problem
subresources.snapshot.storage.k8s.ioto storage-foundation'ssubresources.storage-foundation.deckhouse.io(version unchanged, stillv1)Warning: 299header) — clients are not meant to rely on itaggapiclient was still hardcoded to the old group, with no fallback intended on either sideFix
VSConnectorGroupnow points atsubresources.storage-foundation.deckhouse.io; no dual-group or fallback logic addedVolumeSnapshotVersionout ofVSConnectorVersion:snapimport's CSI VolumeSnapshot RESTMapping call was borrowing the subresources group's version constant, which only worked because both happened to equal"v1"client_test.go, and the group name in thenode.gocommentBefore / After
Before:
d8 snapshot download/upload/restoreagainst a CSIVolumeSnapshotleaf addressessubresources.snapshot.storage.k8s.io.After: the same commands address
subresources.storage-foundation.deckhouse.io— same path shape, same body, only the group name changes.Tests
TestDownloadPath/TestSubresourcePath/TestUploadPath/TestAggregatedAPIContract— VS-leaf expectations updated to the new groupTestConfig_VolumeSnapshotResource— new regression test pinning the literal CSI wire version, guards against reintroducing theVSConnectorVersion/VolumeSnapshotVersionmix-upNotes
Manually verified against a live cluster: discovery serves the new group, and
download/uploadagainst a real CSIVolumeSnapshotleaf both succeed end-to-end.