Bind canary proof to one manager session - #54
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bfe05bebb4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const managerSessionId = | ||
| linkedPairs.length === 1 ? (linkedPairs[0]?.split("\0")[0] ?? null) : null; |
There was a problem hiding this comment.
Select the unique parent rather than a unique review pair
When a canary legitimately completes two reviewer dispatches in the same manager session—for example, the first review reports a finding and a second review passes after repair—each task has a different child session, so linkedPairs.length is 2 even though both pairs have the same parent. This sets managerSessionId to null, empties managerCalls, and incorrectly fails every transcript-derived check. Determine uniqueness from the lineage parent IDs while allowing multiple reviewer children belonging to that one parent.
Useful? React with 👍 / 👎.
Summary
Verification
bun run check: 587 passed, 1 intentional skipbun run replay: 13 of 13 cassettes reproduced