Repository navigation
publish: don't abort tagging when the version was already committed - #47
Merged
Merged
Conversation
When a release version is bumped via a merged PR (the normal flow), the working tree is clean by the time publish.sh reaches its commit step, so `git commit -m "Release $VERSION"` failed with 'nothing to commit' and, under `set -e`, aborted the script before `git tag`/`git push --tags` ran. That is why 0.6.10 published to PyPI but was never tagged. Now the script commits the bump only when something is actually staged, tags the current commit either way, skips the tag if it already exists (a re-run after a partial publish), and pushes the tag explicitly so it lands even when the branch push is a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a release version is bumped via a merged PR (the normal flow), the working tree is clean by the time publish.sh reaches its commit step, so
git commit -m "Release $VERSION"failed with 'nothing to commit' and, underset -e, aborted the script beforegit tag/git push --tagsran. That is why 0.6.10 published to PyPI but was never tagged.Now the script commits the bump only when something is actually staged, tags the current commit either way, skips the tag if it already exists (a re-run after a partial publish), and pushes the tag explicitly so it lands even when the branch push is a no-op.