Repository navigation
import: map erwin UDPs and naming conventions; gitignore the schemas - #46
Merged
Merged
Conversation
The erwin importer skipped ~17 object types. Validated the requested ones against the real XSD schemas and mapped the two with clean IR homes: - UDP_Definition / UDP_Instance -> the IR udp dict (already on entity, attribute, relationship, key_group, domain), which flows to dbt meta:. _read_props now captures a UDP_Instance_Groups nested in an object's <XxxProps>; a def-id index resolves each instance's name (by the name attr, else the UDP_Definition Name, else the raw GUID so nothing is lost). - Naming_Options -> ProjectConfig.naming: Case_Conversion_Type UPPER/LOWER map to physical/logical case, honouring Is_Physical_Only/Is_Logical_Only. Both are additive optional IR fields, so objects without them are unchanged (udp stays None), and the three types no longer emit skip warnings. Deferred (need a real export XML / no IR home this round): Data_Vault_Object and _Properties (not even in these schemas — a Data Vault edition export; target is LogicalEntity.pattern), and Name_Mapping (source lineage). Also gitignore erwin/ — the vendored XSD schemas (4.5MB) were untracked but committable; they must not ship in a public repo. CLI 0.6.11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The erwin importer skipped ~17 object types. Validated the requested ones against the real XSD schemas and mapped the two with clean IR homes:
Both are additive optional IR fields, so objects without them are unchanged (udp stays None), and the three types no longer emit skip warnings.
Deferred (need a real export XML / no IR home this round): Data_Vault_Object and _Properties (not even in these schemas — a Data Vault edition export; target is LogicalEntity.pattern), and Name_Mapping (source lineage).
CLI 0.6.11.