Repository navigation
fix: publish TypeScript declarations at the package paths declared in… - #129
Merged
Merged
Conversation
… `package.json` again, using a dedicated `tsconfig.build.json`, and fail the build when the declared types file is missing (0.12.5) The vite-plugin-dts 5.0.2 update (#122) broke the interplay between the plugin `include` option and its entry-root inference: declarations landed under `dist/src/` while `package.json` points at `dist/Jsonjsdb.d.ts`, so jsonjsdb 0.12.3 and 0.12.4 resolve as untyped in consuming projects. A dedicated `tsconfig.build.json` with an explicit `rootDir` makes the output layout deterministic, and a `postbuild` check now fails CI and release builds if the declared types file is ever missing again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
package.jsonagain, using a dedicatedtsconfig.build.json, and fail the build when the declared types file is missing (0.12.5)The vite-plugin-dts 5.0.2 update (#122) broke the interplay between the plugin
includeoption and its entry-root inference: declarations landed underdist/src/whilepackage.jsonpoints atdist/Jsonjsdb.d.ts, so jsonjsdb 0.12.3 and 0.12.4 resolve as untyped in consuming projects. A dedicatedtsconfig.build.jsonwith an explicitrootDirmakes the output layout deterministic, and apostbuildcheck now fails CI and release builds if the declared types file is ever missing again.