Delete integration tests fully covered by acceptance - #6113
Merged
Conversation
Collaborator
Integration test reportCommit: 4918ebc
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Top 3 slowest tests (at least 2 minutes):
|
version, auth describe, api get/post, and the unknown-command test are all CLI-driven, and every product-code block they execute is also covered by the acceptance suite. Removing them. Verified by generating each test's in-process coverage (-coverpkg) and checking that its covered blocks are a subset of the union of per-test acceptance coverage (CLI_GOCOVERDIR). Residual gaps were confined to the integration harness (internal/testcli, internal/testutil) and cmdio tty/HasIO probing, none of which is command logic. Co-authored-by: Isaac
denik
force-pushed
the
denik/delete-redundant-integration-tests
branch
from
July 31, 2026 10:39
0626b4f to
4918ebc
Compare
andrewnester
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests (version, auth describe, api get/post, unknown-command) are CLI-driven, and every product-code block they execute is also covered by the acceptance suite.
Why
Acceptance tests run the same CLI and can run on cloud too (Cloud=true, real WorkspaceClient when CLOUD_ENV is set), so there's no reason to keep a duplicate in integration/. Verified by generating each test's in-process coverage (-coverpkg) and confirming its covered blocks are a subset of the union of per-test acceptance coverage (CLI_GOCOVERDIR); the only residual gaps were in the test harness itself (internal/testcli, internal/testutil) and cmdio tty/HasIO probing, not command logic.