Skip to content

fix(dash-spv)!: verify MnListDiff against its block's coinbase before applying - #1200

Open
ZocoLini wants to merge 1 commit into
devfrom
fix/verify-mnlistdiff-roots
Open

ZocoLini wants to merge 1 commit into
devfrom
fix/verify-mnlistdiff-roots

fix(dash-spv)!: verify MnListDiff against its block's coinbase before…

0499656
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 23, 2026 in 1s

79.19% (+0.02%) compared to 70a1256

View this Pull Request on Codecov

79.19% (+0.02%) compared to 70a1256

Details

Codecov Report

❌ Patch coverage is 96.89119% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.19%. Comparing base (70a1256) to head (0499656).
⚠️ Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
dash-spv/src/validation/masternode_list.rs 86.66% 4 Missing ⚠️
dash/src/sml/masternode_list/merkle_roots.rs 95.12% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1200      +/-   ##
==========================================
+ Coverage   79.17%   79.19%   +0.02%     
==========================================
  Files         304      305       +1     
  Lines       81288    81424     +136     
==========================================
+ Hits        64360    64485     +125     
- Misses      16928    16939      +11     
Files with missing lines Coverage Δ
dash-spv/src/sml_engine.rs 98.13% <100.00%> (+0.05%) ⬆️
dash-spv/src/storage/masternode.rs 99.55% <100.00%> (+<0.01%) ⬆️
dash-spv/src/sync/masternodes/sync_manager.rs 98.87% <100.00%> (+0.01%) ⬆️
dash/src/merkle_tree/block.rs 87.77% <100.00%> (+0.74%) ⬆️
dash/src/network/message_sml.rs 90.90% <100.00%> (+10.90%) ⬆️
dash/src/sml/error.rs 0.00% <ø> (ø)
dash/src/sml/masternode_list/from_diff.rs 92.40% <100.00%> (-0.62%) ⬇️
dash/src/sml/masternode_list/merkle_roots.rs 97.84% <95.12%> (+32.09%) ⬆️
dash-spv/src/validation/masternode_list.rs 86.66% <86.66%> (ø)

... and 18 files with indirect coverage changes