Repository navigation
refactor(platform): fold DRIVE_ABCI_QUERY_VERSIONS_V3 into V2 - #5057
Conversation
#4266 added DRIVE_ABCI_QUERY_VERSIONS_V2 for protocol version 14 and #4384 added V3 on top of it for the same unreleased version, so V2 was selected by no protocol version. A second feature landing in the same protocol version amends that version's table in place. V2 now carries both slot changes (compute_aggregate_mode_and_check_limit 2, latest_versions_read 1) and PLATFORM_V14 selects it; the values protocol version 14 sees are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 20 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: dashpay/platform/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📖 Book Preview built successfully. Download the preview from the workflow artifacts. Updated at 2026-09-27T16:57:00.423Z |
|
🕓 Queued for automated review — 5th in line, estimated start in ~40 min (commit 86b6da1)
|
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
Verified the changes at 143ceed: folding V3 into V2 preserves protocol version 14's effective query settings and leaves earlier protocol versions unchanged. No blocking issues were found; one documentation listing still names the deleted file. Validation passed: cargo test -p platform-version --offline (26 tests) and git diff --check.
💬 1 nitpick(s)
1 finding(s) not shown inline (the lines are not part of this PR's diff)
💬 Nitpick: Update the query-table directory listing after removing V3
book/src/versioning/feature-versions.md:570
The repository-tree listing still shows v0.rs .. v3.rs under drive_abci_query_versions/, but this PR deletes v3.rs and the directory now contains only mod.rs, v0.rs, v1.rs, and v2.rs. Change the endpoint to v2.rs so the listing agrees with the updated example earlier in this chapter and the actual source tree.
v0.rs .. v2.rs
source: glm-5.3-flash (phase1-reviewer: general, rust-quality)
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: glm-5.3-flash (agent: phase1-reviewer, role: rust-quality); reviewer 3: gpt-6-astra (agent: phase2-reviewer, role: general); reviewer 4: gpt-6-astra (agent: phase2-reviewer, role: architecture-layering); reviewer 5: gpt-6-astra (agent: phase2-reviewer, role: platform-versioning); reviewer 6: gpt-6-astra (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6-astra (agent: astra-verifier, role: final-verifier)
- Triage:
lowbygpt-6-astra(effort low) — The diff is a small, contained table consolidation that preserves protocol version 14’s effective query settings, removes a redundant public constant, and updates references and documentation without changing query logic or consensus behavior. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer,glm-5.3-flash— rust-quality (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 91% left, weekly 33% left; passed overgemini-3.8-flash-high(antigravity below 15% reserve: weekly 13% left, 5h 100% left) - Fresh verifier:
gpt-6-astra— final-verifier; agentastra-verifier - Phase 2 reviewers:
gpt-6-astra— general (completed, effort medium); agentphase2-reviewer,gpt-6-astra— architecture-layering (completed, effort medium); agentphase2-reviewer,gpt-6-astra— platform-versioning (completed, effort medium); agentphase2-reviewer,gpt-6-astra— rust-quality (completed, effort medium); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `book/src/versioning/feature-versions.md`:
- [NITPICK] book/src/versioning/feature-versions.md:570: Update the query-table directory listing after removing V3
The repository-tree listing still shows `v0.rs .. v3.rs` under `drive_abci_query_versions/`, but this PR deletes `v3.rs` and the directory now contains only `mod.rs`, `v0.rs`, `v1.rs`, and `v2.rs`. Change the endpoint to `v2.rs` so the listing agrees with the updated example earlier in this chapter and the actual source tree.
|
Bots are done — your move: post |
…chapter Review follow-up: the directory listing still ended at v3.rs, which this PR removes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Basic explanation
What this does: protocol settings live in versioned tables, and each protocol version points at one table per area. For protocol version 14 (unreleased), the query settings table got a new version twice: V2 for ranked queries, then V3 on top of it for
HAVINGqueries and contract-version reads. V2 ended up used by nothing. This merges V3's two settings into V2, deletes V3, and points protocol version 14 at V2.Value: the tables follow the rule the project uses: one new table version per protocol version, so every table constant belongs to some protocol version and readers do not have to wonder what V2 was for.
Risks: None for behaviour. Protocol version 14 sees exactly the same query settings; no other version referenced V2 or V3.
Issue being fixed or feature implemented
book/src/contributing/coding-conventions.md("Table versions follow protocol-version boundaries, not PRs"): if the unreleased protocol version already introduced a new table version, a second feature landing in the same protocol version amends it in place; adding another table version leaves one referenced by noPLATFORM_V*.DRIVE_ABCI_QUERY_VERSIONS_V2(#4266) was only reachable through..DRIVE_ABCI_QUERY_VERSIONS_V2in V3 (#4384).What was done?
drive_abci_query_versions/v2.rsnow holds both protocol version 14 changes on top of V1 (compute_aggregate_mode_and_check_limit: 2,latest_versions_read: 1), with the combined doc comment.drive_abci_query_versions/v3.rsremoved;PLATFORM_V14selectsDRIVE_ABCI_QUERY_VERSIONS_V2.versioning/feature-versions.md,versioning/platform-version.md) now show V2.Before / after (values unchanged):
How Has This Been Tested?
cargo test -p platform-version,cargo check -p drive-abci --tests,cargo clippy -p platform-version --all-features --all-targets -- -D warnings.Breaking Changes
None.
DRIVE_ABCI_QUERY_VERSIONS_V3is gone from the publicplatform-versionAPI; nothing outside the crate used it.Checklist:
structure.rs, regeneratedgrovedb-structure.json, and checked the structure viewer link posted on this pull requestFor repository code-owners and collaborators only
🤖 Generated with Claude Code
PR Hygiene ·
86b6da1/skip-botsproceeds without the ones not yet reported/self-reviewedonce the bots are doneWhen every box is checked the
PR Hygienecheck passes and this can merge.