Skip to content

refactor(platform): fold DRIVE_ABCI_QUERY_VERSIONS_V3 into V2 - #5057

Merged
QuantumExplorer merged 2 commits into
v4.2-devfrom
claude/fold-query-versions-v3
Sep 27, 2026
Merged

QuantumExplorer merged 2 commits into
v4.2-devfrom
claude/fold-query-versions-v3

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Basic explanation

What this does: protocol settings live in versioned tables, and each protocol version points at one table per area. For protocol version 14 (unreleased), the query settings table got a new version twice: V2 for ranked queries, then V3 on top of it for HAVING queries and contract-version reads. V2 ended up used by nothing. This merges V3's two settings into V2, deletes V3, and points protocol version 14 at V2.

Value: the tables follow the rule the project uses: one new table version per protocol version, so every table constant belongs to some protocol version and readers do not have to wonder what V2 was for.

Risks: None for behaviour. Protocol version 14 sees exactly the same query settings; no other version referenced V2 or V3.

Issue being fixed or feature implemented

book/src/contributing/coding-conventions.md ("Table versions follow protocol-version boundaries, not PRs"): if the unreleased protocol version already introduced a new table version, a second feature landing in the same protocol version amends it in place; adding another table version leaves one referenced by no PLATFORM_V*. DRIVE_ABCI_QUERY_VERSIONS_V2 (#4266) was only reachable through ..DRIVE_ABCI_QUERY_VERSIONS_V2 in V3 (#4384).

What was done?

  • drive_abci_query_versions/v2.rs now holds both protocol version 14 changes on top of V1 (compute_aggregate_mode_and_check_limit: 2, latest_versions_read: 1), with the combined doc comment.
  • drive_abci_query_versions/v3.rs removed; PLATFORM_V14 selects DRIVE_ABCI_QUERY_VERSIONS_V2.
  • The two book chapters that showed V3 (versioning/feature-versions.md, versioning/platform-version.md) now show V2.

Before / after (values unchanged):

PLATFORM_V14.drive_abci.query
before: DRIVE_ABCI_QUERY_VERSIONS_V3 = V1 + { compute_aggregate_mode_and_check_limit: 2, latest_versions_read: 1 }
after:  DRIVE_ABCI_QUERY_VERSIONS_V2 = V1 + { compute_aggregate_mode_and_check_limit: 2, latest_versions_read: 1 }

How Has This Been Tested?

cargo test -p platform-version, cargo check -p drive-abci --tests, cargo clippy -p platform-version --all-features --all-targets -- -D warnings.

Breaking Changes

None. DRIVE_ABCI_QUERY_VERSIONS_V3 is gone from the public platform-version API; nothing outside the crate used it.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed
  • If I added or changed GroveDB structure, I described it in the area's structure.rs, regenerated grovedb-structure.json, and checked the structure viewer link posted on this pull request

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

PR Hygiene · 86b6da1

  • Bots — coderabbitai not yet · thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — post /self-reviewed once the bots are done
  • Within your 5 open PRs
  • Build running
  • Approvals — you own every area touched; none needed

When every box is checked the PR Hygiene check passes and this can merge.

#4266 added DRIVE_ABCI_QUERY_VERSIONS_V2 for protocol version 14 and #4384
added V3 on top of it for the same unreleased version, so V2 was selected
by no protocol version. A second feature landing in the same protocol
version amends that version's table in place. V2 now carries both slot
changes (compute_aggregate_mode_and_check_limit 2, latest_versions_read 1)
and PLATFORM_V14 selects it; the values protocol version 14 sees are
unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: dashpay/platform/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: e1009a2b-8696-47bf-9eff-d24a12771d76

📥 Commits

Reviewing files that changed from the base of the PR and between 4d4f38d and 86b6da1.

📒 Files selected for processing (6)
  • book/src/versioning/feature-versions.md
  • book/src/versioning/platform-version.md
  • packages/rs-platform-version/src/version/drive_abci_versions/drive_abci_query_versions/mod.rs
  • packages/rs-platform-version/src/version/drive_abci_versions/drive_abci_query_versions/v2.rs
  • packages/rs-platform-version/src/version/drive_abci_versions/drive_abci_query_versions/v3.rs
  • packages/rs-platform-version/src/version/v14.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

📖 Book Preview built successfully.

Download the preview from the workflow artifacts.
To view locally: download the artifact, unzip, and open index.html.

Updated at 2026-09-27T16:57:00.423Z

@github-actions github-actions Bot added this to the v4.2.0 milestone Sep 27, 2026
@thepastaclaw

thepastaclaw commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

🕓 Queued for automated review — 5th in line, estimated start in ~40 min (commit 86b6da1)
Estimated review time once started: ~1.4 h (two-phase automated review; median of recent runs).

  • Request priority review — click to move this review to the front of the queue.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Sep 27, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

Verified the changes at 143ceed: folding V3 into V2 preserves protocol version 14's effective query settings and leaves earlier protocol versions unchanged. No blocking issues were found; one documentation listing still names the deleted file. Validation passed: cargo test -p platform-version --offline (26 tests) and git diff --check.

💬 1 nitpick(s)

1 finding(s) not shown inline (the lines are not part of this PR's diff)

💬 Nitpick: Update the query-table directory listing after removing V3
book/src/versioning/feature-versions.md:570

The repository-tree listing still shows v0.rs .. v3.rs under drive_abci_query_versions/, but this PR deletes v3.rs and the directory now contains only mod.rs, v0.rs, v1.rs, and v2.rs. Change the endpoint to v2.rs so the listing agrees with the updated example earlier in this chapter and the actual source tree.

      v0.rs .. v2.rs

source: glm-5.3-flash (phase1-reviewer: general, rust-quality)

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: glm-5.3-flash (agent: phase1-reviewer, role: rust-quality); reviewer 3: gpt-6-astra (agent: phase2-reviewer, role: general); reviewer 4: gpt-6-astra (agent: phase2-reviewer, role: architecture-layering); reviewer 5: gpt-6-astra (agent: phase2-reviewer, role: platform-versioning); reviewer 6: gpt-6-astra (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6-astra (agent: astra-verifier, role: final-verifier)

  • Triage: low by gpt-6-astra (effort low) — The diff is a small, contained table consolidation that preserves protocol version 14’s effective query settings, removes a redundant public constant, and updates references and documentation without changing query logic or consensus behavior.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer, glm-5.3-flash — rust-quality (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 91% left, weekly 33% left; passed over gemini-3.8-flash-high (antigravity below 15% reserve: weekly 13% left, 5h 100% left)
  • Fresh verifier: gpt-6-astra — final-verifier; agent astra-verifier
  • Phase 2 reviewers: gpt-6-astra — general (completed, effort medium); agent phase2-reviewer, gpt-6-astra — architecture-layering (completed, effort medium); agent phase2-reviewer, gpt-6-astra — platform-versioning (completed, effort medium); agent phase2-reviewer, gpt-6-astra — rust-quality (completed, effort medium); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `book/src/versioning/feature-versions.md`:
- [NITPICK] book/src/versioning/feature-versions.md:570: Update the query-table directory listing after removing V3
  The repository-tree listing still shows `v0.rs .. v3.rs` under `drive_abci_query_versions/`, but this PR deletes `v3.rs` and the directory now contains only `mod.rs`, `v0.rs`, `v1.rs`, and `v2.rs`. Change the endpoint to `v2.rs` so the listing agrees with the updated example earlier in this chapter and the actual source tree.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head labels Sep 27, 2026
…chapter

Review follow-up: the directory listing still ended at v3.rs, which this
PR removes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added waiting-bots Waiting for the review bots to report on this head and removed waiting-self-review Waiting for the author to post /self-reviewed bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. labels Sep 27, 2026
@QuantumExplorer
QuantumExplorer merged commit 5c8c4dd into v4.2-dev Sep 27, 2026
14 of 15 checks passed
@QuantumExplorer
QuantumExplorer deleted the claude/fold-query-versions-v3 branch September 27, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants