Skip to content

Possibly ignore shutdown request - #21746

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:possibly_ignore_shutdown
Aug 7, 2026
Merged

Possibly ignore shutdown request#21746
TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:possibly_ignore_shutdown

Conversation

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator

As every shutdown request is restarting the pipe it's better to ignore them by resetting shutdown to DT_DEV_PIXELPIPE_PROCESSING if

  • we do mask visualizing or are in fast pipe mode
  • we are very late in the pipe

Fixes #21743

As every shutdown request is restarting the pipe it's better to ignore them
by resetting shutdown to DT_DEV_PIXELPIPE_PROCESSING if
- we do mask visualizing or are in fast pipe mode
- we are very late in the pipe
@jenshannoschwalm jenshannoschwalm added this to the 5.8 milestone Aug 7, 2026
@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug priority: medium core features are degraded in a way that is still mostly usable, software stutters scope: UI user interface and interactions scope: performance doing everything the same but faster labels Aug 7, 2026
@AxelG-DE

AxelG-DE commented Aug 7, 2026

Copy link
Copy Markdown
  • Tested.
  • Does the trick for me :-)

Thanks!

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator Author
  • Tested.

    • Does the trick for me :-)

Thanks!

Thanks for confirming ...

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit fc3b5ba into darktable-org:master Aug 7, 2026
5 checks passed
@AxelG-DE

AxelG-DE commented Aug 7, 2026

Copy link
Copy Markdown

Sorry for abusing this conversation:

I just noticed, the tone equaliser’s mask histogram on advanced tab of toneEQ runs smoothly when compensation sliders are moved. However when heavy modules applied, it is getting sticky and my fans telling me the whole pipe is getting calculated. Is that unavoidable?

@AxelG-DE

AxelG-DE commented Aug 7, 2026

Copy link
Copy Markdown

heavy modules as in diffuse or sharpen"

@jenshannoschwalm
jenshannoschwalm deleted the possibly_ignore_shutdown branch August 7, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug priority: medium core features are degraded in a way that is still mostly usable, software stutters scope: performance doing everything the same but faster scope: UI user interface and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

performance regression on attenuation of masks

3 participants