Repository navigation
fix: one-sided dice and empty penetrating dice - #13
Merged
Merged
Conversation
A one-sided die is deterministic, so it is folded to its fixed value without being rolled and skips rerolls and explosions, which lets d1 work without looping forever. A penetrating die whose reduced face reaches zero can no longer be rolled, so it is dropped from the results instead of appearing as a zero. Fixes #12 Fixes #9 💘 Generated with Crush Assisted-by: Crush:deepseek-v4.1-flash
Record the new one-sided die and penetrating-zero semantics in the design spec and implementation plan. 💘 Generated with Crush Assisted-by: Crush:deepseek-v4.1-flash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d1is deterministic, so it is folded to its fixed value without rolling and skips rerolls/explosions, which stops4d1!/4d1r1from looping forever. Only a size of zero or less is still rejected.0, so the total is unchanged.Adds
onesided_test.go, updates the penetrating spec expectations (plus a kept-reduction case), and rebuilds the wasm bundle.Fixes #12
Fixes #9
💘 Generated with Crush