Skip to content

fix(plugin-basic-ui): respect Modal and BottomSheet safe areas - #770

Merged
ENvironmentSet merged 1 commit into
mainfrom
feature/fep-3133
Oct 27, 2026
Merged

ENvironmentSet merged 1 commit into
mainfrom
feature/fep-3133

Conversation

@ENvironmentSet

@ENvironmentSet ENvironmentSet commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Modal and BottomSheet do not account for device safe area insets, so content can be obscured by cutouts or the home indicator.

Center Modal within the safe area on all four sides, and add left, right, and bottom inset padding to BottomSheet content while keeping its background edge-to-edge.

@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 14ec96f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stackflow/plugin-basic-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between b3a07c6 and 14ec96f.

Files selected for processing: 5
  • .changeset/tidy-modals-respect-insets.md
  • docs/pages/api-references/plugins/plugin-basic-ui.en.mdx
  • docs/pages/api-references/plugins/plugin-basic-ui.ko.mdx
  • extensions/plugin-basic-ui/src/components/BottomSheet.css.ts
  • extensions/plugin-basic-ui/src/components/Modal.css.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Modal content is centered within the safe area, while its backdrop remains full-screen.
    • Bottom sheets now account for left, right, and bottom safe-area insets while keeping their background full-width and bottom-aligned.
  • Documentation
    • Updated safe-area guidance for modals and bottom sheets, including how to avoid duplicate inset spacing.

Modal and BottomSheet styles now apply safe-area insets. The API documentation describes their inset behavior and guidance for avoiding duplicate child adjustments.

Changes: Modal safe-area handling

Layer / File(s) Summary
Inset styles and usage guidance
extensions/plugin-basic-ui/src/components/Modal.css.ts, extensions/plugin-basic-ui/src/components/BottomSheet.css.ts, docs/pages/api-references/plugins/plugin-basic-ui.en.mdx, docs/pages/api-references/plugins/plugin-basic-ui.ko.mdx, .changeset/tidy-modals-respect-insets.md
Modal applies all four safe-area insets. BottomSheet applies left, right, and bottom insets as internal padding. The documentation describes these rules and identifies duplicate child inset adjustments.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to 14ec9

The safe-area changes are consistent across implementation and documentation and are ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: adding safe-area support for Modal and BottomSheet in plugin-basic-ui.
Description check Passed The description directly explains the safe-area problem and the Modal and BottomSheet changes in the changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (3 skipped: 3 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying stackflow-demo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 14ec96f
Status: ✅  Deploy successful!
Preview URL: https://7cb0f7f1.stackflow-demo.pages.dev
Branch Preview URL: https://feature-fep-3133.stackflow-demo.pages.dev

View logs

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026

Copy link
Copy Markdown
  • @stackflow/demo

    yarn add https://pkg.pr.new/@stackflow/plugin-basic-ui@770.tgz
    

commit: 14ec96f

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
stackflow-docs 14ec96f Commit Preview URL Oct 23 2026, 11:04 AM

@ENvironmentSet
ENvironmentSet marked this pull request as ready for review October 27, 2026 06:49
@ENvironmentSet
ENvironmentSet merged commit 1f595cc into main Oct 27, 2026
12 checks passed
@ENvironmentSet
ENvironmentSet deleted the feature/fep-3133 branch October 27, 2026 06:59
@coderabbitai coderabbitai Bot mentioned this pull request Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant