Repository navigation
fix(plugin-basic-ui): respect Modal and BottomSheet safe areas - #770
Conversation
🦋 Changeset detectedLatest commit: 14ec96f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Inset styles and usage guidance extensions/plugin-basic-ui/src/components/Modal.css.ts, extensions/plugin-basic-ui/src/components/BottomSheet.css.ts, docs/pages/api-references/plugins/plugin-basic-ui.en.mdx, docs/pages/api-references/plugins/plugin-basic-ui.ko.mdx, .changeset/tidy-modals-respect-insets.md |
Modal applies all four safe-area insets. BottomSheet applies left, right, and bottom insets as internal padding. The documentation describes these rules and identifies duplicate child inset adjustments. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Merge Risk: 
Minimal · up to 14ec9
-
The safe-area changes are consistent across implementation and documentation and are ready to merge.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (3 skipped: 3 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Deploying stackflow-demo with
|
| Latest commit: |
14ec96f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7cb0f7f1.stackflow-demo.pages.dev |
| Branch Preview URL: | https://feature-fep-3133.stackflow-demo.pages.dev |
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
stackflow-docs | 14ec96f | Commit Preview URL | Oct 23 2026, 11:04 AM |
Modal and BottomSheet do not account for device safe area insets, so content can be obscured by cutouts or the home indicator.
Center Modal within the safe area on all four sides, and add left, right, and bottom inset padding to BottomSheet content while keeping its background edge-to-edge.