chore(deps): upgrade vite toolchain to v8 - #897
Merged
Conversation
@vitejs/plugin-react@6 requires vite ^8.0.0 as a peer dependency, which the 5.2.0->6.0.5 Renovate PR (#888) could not satisfy against the repo's pinned vite@7.3.6, failing the build with ERR_PACKAGE_PATH_NOT_EXPORTED on the vite/internal subpath. Bump vite (7.3.6->8.2.1), @vitejs/plugin-react (5.2.0->6.0.5), and vite-plugin-dts (4.5.4->5.0.3, its own vite-8-compatible major) together across client/local/runtime/storybook. Drop the now-redundant esbuild.supported.top-level-await override in client/vite.config.ts (vite 8's rolldown/oxc default transformer ignores it; build.target: 'esnext' already covers it) and the import-x/default eslint-disable comments made unnecessary by vite-plugin-dts 5's default export. Group @vitejs/plugin-react into the existing "vite" Renovate group alongside vite and vite-plugin-dts so future bumps stay in lockstep instead of reproducing this peer-dependency mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Renovate PR #888(
@vitejs/plugin-react5.2.0→6.0.5)のCIが継続的に失敗していた。原因は
@vitejs/plugin-react@6.0.5がpeerDependenciesでvite: ^8.0.0を要求するのに対し、リポジトリのviteは7.3.6に固定されており、ビルド時に以下のエラーで失敗していたこと。変更内容
vite:7.3.6→8.2.1(client/local/runtime/storybook)@vitejs/plugin-react:5.2.0→6.0.5(client。PR #888と同内容)vite-plugin-dts:4.5.4→5.0.3(client/runtime。vite 8対応の同時メジャーアップ)client/vite.config.ts:esbuild.supported['top-level-await']を削除build.target: 'esnext'で実質的にカバーされており、ソース中にトップレベルawaitの使用もないため削除client/vite.config.ts,runtime/vite.config.ts:// eslint-disable-next-line import-x/defaultコメントを削除vite-plugin-dts5.0.3がdefault exportを正規に持つようになったため不要に.github/renovate.json:viteグループに@vitejs/plugin-reactを追加vite/vite-plugin-dtsグループに合流検証
yarn build: 16プロジェクト全て成功yarn lint: エラーなし(既存warning 4件のみ、変更と無関係)yarn test(Docker経由、VR含む): 99ファイル / 1059テスト成功、VR差分なしlocal/src/commands/server.spec.tsのCLI起動待ちタイムアウトが4回中1回失敗したが、既存issue #841と同種のDocker内CPU競合によるflakyと判断(4回中3回成功、今回の変更とは無関係)。スコープ外のため対応せず影響範囲
exportsの変更なし