fix: WillPopScope migration - #1375
Open
sneurlax wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1375 +/- ##
========================================
Coverage 4.84% 4.84%
========================================
Files 1092 1092
Lines 109141 109069 -72
========================================
+ Hits 5283 5286 +3
+ Misses 103858 103783 -75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
sneurlax
marked this pull request as draft
August 20, 2026 18:58
WillPopScope is deprecated and cannot take part in Android predictive back. Static vetoes become canPop, callbacks that navigate on their own move to onPopInvokedWithResult, and the sheets that pop a value declare the result type of the route they close.
sneurlax
force-pushed
the
fix/WillPopScope
branch
from
August 20, 2026 21:27
ab8a128 to
e416103
Compare
sneurlax
marked this pull request as ready for review
August 20, 2026 23:46
PopScope decides canPop synchronously, so the eight screens that awaited a decision in onWillPop get a wrapper that runs the callback from onPopInvokedWithResult, coalesces repeated presses, and reproduces Route.popDisposition: an approved back on the first route is handed to the platform rather than emptying the navigator.
sneurlax
force-pushed
the
fix/WillPopScope
branch
from
August 25, 2026 00:03
851c0fe to
be5f6f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the deprecated WillPopScope widget to PopScope across the app. Simple barrier dialogs become canPop: false/true. Cases that ran side effects or conditionally gated the pop move that work into onPopInvokedWithResult.