feat: "Generate new address" button to wallet address list views - #1358
Draft
sneurlax wants to merge 2 commits into
Draft
feat: "Generate new address" button to wallet address list views#1358sneurlax wants to merge 2 commits into
sneurlax wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1358 +/- ##
===========================================
- Coverage 5.36% 4.83% -0.53%
===========================================
Files 797 1092 +295
Lines 75915 109196 +33281
===========================================
+ Hits 4075 5283 +1208
- Misses 71840 103913 +32073 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
sneurlax
marked this pull request as draft
August 20, 2026 19:00
No behaviour change; the formatter is enforced on changed files in CI.
Both the mobile and desktop address lists gain a guarded button that derives the next receiving address. GenerateAddressButton owns the whole flow: it suppresses repeat taps, shows a non dismissible progress dialog on the root navigator, closes exactly that dialog's route when generation settles, and surfaces failures instead of stranding the modal. The button is only offered to wallets that can actually derive another address, so view only wallets holding just an address or a spark view key do not get it. closes #430
sneurlax
force-pushed
the
feat/430-generate-address-button
branch
from
August 24, 2026 21:31
1f8f492 to
da800a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #430