Skip to content

feat: crop the Hardcover credit on descriptions set by hand - #52

Merged
itsthisjustin merged 3 commits into
crosspoint-reader:mainfrom
eszter007:feat/manual-description-credit
Oct 26, 2026
Merged

itsthisjustin merged 3 commits into
crosspoint-reader:mainfrom
eszter007:feat/manual-description-credit

Conversation

@eszter007

Copy link
Copy Markdown
Contributor

After you edit a book's description, the About card still says "via Hardcover", which is no longer true.

GET /documents/{document}/about now also returns manual, true when the description was set with PUT /info. The web app hides the credit in that case. The field is new, so older clients keep working and just keep showing the credit.

Tests: server and app suites pass, plus a new check that manual turns true after a manual description.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3c61523b-daa2-48a2-8594-cc5e8ce86349
Commits

Reviewing files that changed from the base of the PR and between 650fe1d and 86c625e.

Files selected for processing: 5
  • app/src/Book.jsx
  • app/src/Book.test.jsx
  • docs/API.md
  • src/routes/v1/documents.ts
  • test/hardcover-catalog.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Additional comments: 5
src/routes/v1/documents.ts: 1

217-217: LGTM!

Also applies to: 226-228

test/hardcover-catalog.test.ts: 1

110-111: LGTM!

Also applies to: 121-124

docs/API.md: 1

725-729: LGTM!

app/src/Book.jsx: 1

858-858: LGTM!

app/src/Book.test.jsx: 1

227-238: LGTM!

Walkthrough

The /about endpoint now reports whether a description was set manually. The book view uses that value to show the Hardcover attribution only for non-manual descriptions.

Changes: Description Attribution

Layer / File(s) Summary
About endpoint manual flag
src/routes/v1/documents.ts, test/hardcover-catalog.test.ts, docs/API.md
The endpoint returns a manual boolean with the nullable description. Tests cover Hardcover-provided and manually updated descriptions. The API documentation describes the response.
Book view attribution
app/src/Book.jsx, app/src/Book.test.jsx
The view omits “via Hardcover” when data.manual is true. The test checks both manual and non-manual descriptions.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

  • crosspoint-reader/crosspoint-sync#51: Adds description editing through PUT /documents/:document/info; this change exposes that description's manual status in /about and uses it in the book view.

Suggested reviewers: itsthisjustin

Merge Risk: Minimal · up to 86c62

The manual-description attribution change is internally consistent and has no identified merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Description check Passed The description clearly explains the manual description behavior, the new API field, the UI change, backward compatibility, and test coverage.
Title check Passed The title clearly identifies the main change: removing the Hardcover credit when descriptions are set by hand.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eszter007
eszter007 marked this pull request as ready for review October 26, 2026 09:50
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-26T09:52:10.452055Z
We couldn’t complete this review. Comment @codex review to try again.
86c625e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@eszter007 eszter007 changed the title Drop the Hardcover credit on descriptions set by hand fix: rop the Hardcover credit on descriptions set by hand Oct 26, 2026
@eszter007 eszter007 changed the title fix: rop the Hardcover credit on descriptions set by hand feat: crop the Hardcover credit on descriptions set by hand Oct 26, 2026
@itsthisjustin
itsthisjustin merged commit e41072c into crosspoint-reader:main Oct 26, 2026
4 checks passed
@eszter007
eszter007 deleted the feat/manual-description-credit branch October 26, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants