Repository navigation
feat: crop the Hardcover credit on descriptions set by hand - #52
itsthisjustin merged 3 commits into
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
About endpoint manual flag src/routes/v1/documents.ts, test/hardcover-catalog.test.ts, docs/API.md |
The endpoint returns a manual boolean with the nullable description. Tests cover Hardcover-provided and manually updated descriptions. The API documentation describes the response. |
Book view attribution app/src/Book.jsx, app/src/Book.test.jsx |
The view omits “via Hardcover” when data.manual is true. The test checks both manual and non-manual descriptions. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- crosspoint-reader/crosspoint-sync#51: Adds description editing through
PUT /documents/:document/info; this change exposes that description's manual status in/aboutand uses it in the book view.
Suggested reviewers: itsthisjustin
Merge Risk: 
Minimal · up to 86c62
-
The manual-description attribution change is internally consistent and has no identified merge-blocking risk.
Pre-merge checks: 
4
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
After you edit a book's description, the About card still says "via Hardcover", which is no longer true.
GET /documents/{document}/aboutnow also returnsmanual, true when the description was set withPUT /info. The web app hides the credit in that case. The field is new, so older clients keep working and just keep showing the credit.Tests: server and app suites pass, plus a new check that
manualturns true after a manual description.