Repository navigation
fix(evals): align battery with proof v2 contract - #4
Merged
Merged
Conversation
Validate serialized proof with the canonical parser and preserve explicit v1 compatibility, malformed-input rejection, and failed legacy proof gates. Co-Authored-By: Codex gpt-6-astra <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deterministic Webs battery failed after the evals 2.0.1 upgrade because its test still expected proof-run v1. Match the producer's exported version, keep an explicit v1/v2 support boundary, and validate serialized proof with the canonical parser. Regressions reject unknown versions, missing intent/goal, invalid routes/artifacts, and preserve failed assertions and blockers when reading legacy v1 proof.
Only
test/battery.test.tschanges. The existing battery already parses proof before scoring and serialization, so its runtime needs no change. The dependency owner's manifest and lockfile candidate remain separate.Validation on both the committed evals 1.8.0 baseline and the preserved evals 2.0.1 candidate:
pnpm typecheck— passed.pnpm test— 18 passed, 0 failed, 0 skipped in each configuration.pnpm battery— 1 deterministic case passed, score 1.00.pnpm check:generatedandgit diff --check— passed.node --test test/battery.test.tsreproduced 3 passes and 1 v1/v2 mismatch failure; the focused suite then passed all 6 tests.Independent review and the captain's integrated verification remain separate gates.