Conversation
antvaset
approved these changes
Jul 27, 2026
JPercival
approved these changes
Aug 18, 2026
Member
|
@brynrhodes @JPercival @antvaset - There are some failing CI, but they seem related to permissions/env issues, likely because the PR is coming from a branch. Can I force merge this or is there something real that we should be concerned about in the CI? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a couple changes to error handling in the cql-to-elm-cli, as requested (by me) in #1810 .
--write-on-errorwhich will cause output files to be written even if there was a translator error.The basics of the PR are straightforward but there are a few things to note and we may want to discuss further:
--no-write-on-errorto enable the current behaviorrequireused in a couple places.) As of now the CLI really only has a single primary use case, and I don't see anything that looks like it would slip through, but it's worth double checking and something to keep in mind if new features are ever added.Sample runs: