Conversation
CdsResponseEncoderService.resolveAction resolved each child action of a selectionBehavior action via resolveSuggestion but discarded the result, so cards carried a selectionBehavior and no suggestions. Add each resolved suggestion to the card.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CdsResponseEncoderService.resolveActionresolves each child action of aselectionBehavioraction viaresolveSuggestion, but never adds the result to the card:Any PlanDefinition with nested actions therefore produces a card with
selectionBehaviorset and nosuggestions.Fix
Test
Added
testResolveAction_shouldAddSuggestionsForNestedActionsWhenSelectionBehaviorIsSettoResponseEncoderMethodResolveActionTest.