Repository navigation
Run CI nightly at 05:35 UTC and on demand - #62
Merged
Merged
Conversation
Add schedule (cron "35 5 * * *") and workflow_dispatch triggers to ci.yml, keeping push and pull_request as they are. A scheduled run tests the latest commit on main, so a main that goes red with no push behind it is found the next morning. No job needed a guard: nothing in this workflow or the shared reusable one it calls reads pull-request context, and the actionlint step's reporter lints every file outside a pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
mainnow also runs every night, and can be started by hand.What changes
.github/workflows/ci.ymlgets two more triggers.pushandpull_requeststay as they are:A scheduled run tests the latest commit on the default branch. So if
maingoes red with no push behind it (a dependency, a runner image, an expired date, the shared workflow), we find out the next morning.Why no job needed a guard
We read every job and step in this workflow (
ci,examples) and in the reusablecosyte/.github/.github/workflows/ci.yml@mainthatcicalls (verify,prepublish,actionlint). None of them readsgithub.event.pull_request.*,github.head_ref,github.base_ref,github.event.beforeorgithub.event_name, and none diffs against a PR base. No other workflow in this repo is triggered by CI completing, so a nightly run starts nothing else.The shared
actionlintjob runsreviewdog/action-actionlint(imagev1.72.0: reviewdog v0.21.0, actionlint 1.7.12) with its defaultgithub-pr-checkreporter. In reviewdog v0.21.0 (cmd/reviewdog/main.go), inside GitHub Actions with noREVIEWDOG_TOKEN, that reporter skips the doghouse server and, when the build is not a pull request, switches tonofilter. So on a nightly run it still lints every workflow file and still fails on a finding, rather than skipping. Pushes tomainalready take this path and have been green.No job was renamed or dropped, so the required checks (
ci / actionlint,ci / verify (22, ubuntu-latest),ci / verify (24, ubuntu-latest)) are unchanged. A pull-request run checks exactly what it did before.Proof of the non-PR path
gh workflow run ci.yml -R cosyte/transform --ref harness/44-nightly-run-of-ciwas accepted and ran as aworkflow_dispatchevent on the head commit4daf098: https://github.com/cosyte/transform/actions/runs/39355629604It concluded
successon the first attempt, with all five jobs green:ci / verify (22, ubuntu-latest),ci / verify (24, ubuntu-latest),ci / actionlint,ci / prepublishandexamples. Theci / actionlintlog has no "this is not PullRequest build" line, so reviewdog took the linting path rather than skipping.Gate run locally
All passed:
typecheck,lint,format:check,phi-scan,check:no-emdash,ci:no-internal-refs,test(952 tests),test:coverage,build,attw, the dual ESM/CJS smoke, theexamplesjob's four steps (typecheck:examples,lint:examples,examples,phi-scan:examples), and actionlint 1.7.12 over.github/workflows/*.yml.test:coverageat the default worker count (56 here) timed out in thetest/conformance/suites twice, at the 10 s test timeout, while the host's load average was about 45 from other work. Those suites passed alone, the fullpnpm testpassed, andtest:coverage --maxWorkers=8passed with every coverage threshold met. This change touches no test or source file, and CI runs with its own runner.Notes
concurrencygroup is${{ github.workflow }}-${{ github.ref }}withcancel-in-progress: true. A scheduled run and a push run onmaintherefore share one group, and whichever starts second cancels the other. Both test the samemain, and a cancelled run reports no result in either direction. We left it alone because changing it is outside this change's scope.src/or in the published package moves.Harness-Task: 44
🤖 Generated with Claude Code