bugfix per tenant cache ttl fallback - #7775
Open
Shvejan wants to merge 2 commits into
Open
Conversation
Signed-off-by: Shvejan Mutheboyina <shvejan@amazon.com>
Signed-off-by: Shvejan Mutheboyina <shvejan@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Makes
out_of_order_results_cache_ttlfall back toresults_cache_ttlbefore falling back to the global cache backend TTL.Previously, a tenant that set only
results_cache_ttlgot that TTL for data outside the out-of-order window, but the global backend TTL for data insideit. The fallback is resolved per-tenant before aggregating across tenants, since
SmallestPositiveNonZeroDurationPerTenantdiscards zeros and wouldotherwise lose track of which tenant left the value unset.
Which issue(s) this PR fixes:
Fixes #7774
Checklist
[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags