Repository navigation
ci(publish): slack says who triggered the release; tags live test waits for the api - #299
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The nightly integration run of 2026-10-20 failed on "renames the tag": the tag was renamed (the next test deleted it by its new name), but the lookup right after the command still listed the previous state. The live suites get liveEventually, which repeats a lookup until it gives the expected value (20 seconds at most); the tags suite uses it after create, rename and delete. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pviti
changed the title
pviti
marked this pull request as ready for review
October 20, 2026 09:01
cl-mvezzelli
self-requested a review
October 20, 2026 09:01
cl-mvezzelli
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next changes to main
A draft pull request that collects the next changes to main, so they get one review. The title follows the contents and will be updated as changes are added. It is marked ready for review, and the reviewers are requested, when it is complete.
Changes
ci(publish): the Slack message of a release says who triggered it ("has triggered this release."), as in the previous flow, instead of "has merged this release." A release can also start from a manual run of Publish, and the person who merged may not have merged the release PR itself.test(tags): the nightly Integration run of 2026-10-20 (run 39365643065) failed onrenames the tagwithexpected undefined to be a string.The live suites get
liveEventually(packages/test-utils), which repeats a lookup until it returns the expected value, for 20 seconds at most. The tags suite uses it after create, rename and delete. This PR changes the integration suites, so Integration runs on it against the real API.🤖 Generated with Claude Code