Repository navigation
Conversation
Member
Author
|
Closed: opened while cli 7.1.0 (#296) was not published yet, so it proposed the same changes again as 7.2.0. The release script will refuse to open a release PR while versions are pending. |
pviti
added a commit
that referenced
this pull request
Oct 15, 2026
…ing releases (#298) ## Release: git identity for the tags, `release:prepare`, no double releases The release of cli 7.1.0 (#296) showed three problems. ### 1. Publish failed on `git tag` The release tags are annotated, and the GitHub runner has no git identity: `Committer identity unknown`. The previous tags had been created by hand, so this was the first tag Publish created itself. Nothing was published: the job stopped before npm. **Fix:** `publish.yml` sets the identity of `github-actions[bot]` before `cl-release ship`. ### 2. `pnpm release:publish` → `pnpm release:prepare` The script prepares a release (version bump + release PR). The name suggested it publishes, and it was run after the merge, while Publish does that. Docs, comments and messages are updated. ### 3. A second release PR for the same changes (#297, closed) `release:prepare` was run right after the merge of #296, while 7.1.0 was not tagged yet. It compared with `cli-v7.0.0` and proposed the same changes as 7.2.0. **Fix:** `release:prepare` stops while a public package version is not on npm yet: ``` ✖ Not released yet: @commercelayer/cli@7.1.0. Wait for publish.yml to publish them (Actions → Publish; run it again if it failed), then prepare the next release. ``` I checked this on an up-to-date `main` with the tooling of this branch, and that is the message it printed. ###⚠️ On merge Publish runs on the merge commit and **publishes cli 7.1.0**: the tag `cli-v7.1.0`, npm, the GitHub release and Slack. The tooling comes from the merge commit, so it includes the git identity. ### Checks Release package: type-check passes, 26 tests pass. `pnpm lint` and `check-packages` pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging this pull request publishes these versions: publish.yml tags them, publishes them to npm and publishes their GitHub releases.
@commercelayer/cli7.1.0 → 7.2.0 (cli-v7.2.0)Release notes
@commercelayer/cli 7.2.0
7.2.0 (2026-10-15)
Features
Bug Fixes