Repository navigation
fix: cover letter openings spread across projects, a project can be kept out of them, and the addressee's town is a town - #75
Merged
Conversation
…ept out of them, and the addressee's town is a town
Windrush opened most letters because job-ad words (application, career, global, teams) matched a project about job
hunting. Those words no longer count towards relevance. The code now names the project for the hook, and a project
marked "Don't open cover letters with this" is never that project: a letter that still opens on it gets one revision
and is held by autopilot if it stays. It can still be evidence.
The recipient block took the location's first part as it came ("United Kingdom - London", "Belfast 10 Mays Meadow").
It now finds the town, or leaves the line out when there is none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Most letters opened on Windrush. Job-ad words (application, career, global, teams) counted towards relevance and favoured a project about job hunting, and the model opens on whichever project it's told to. The recipient block also took the location's first part as it came, giving lines like "United Kingdom - London" and "Belfast 10 Mays Meadow".
What changed
Project.not_in_openingand a profile tick box, "Don't open cover letters with this project". The project can still be evidence. A letter that opens on it anyway gets one revision, and autopilot holds it if it still does._letter_townfinds the first town in the location, without country, work setting, street address or site. If there's no town, the line is left out.Results
Across 300 recent UK jobs, Windrush ranked first on 88 before the change and on 22 after; with the box ticked it opens none. The most common opening is now Premier League (79), then ColonoScan (71) and Thespis (41). Windrush stayed out of all 12 real test letters across 6 jobs, though one of those letters opened on a different project from the one named.
Testing
Not covered