Skip to content

VNext/support convenience testing in visual studio - #5

Merged
gimlichael merged 5 commits into
masterfrom
vNext/support-convenience-testing-in-visual-studio
Oct 30, 2026
Merged

gimlichael merged 5 commits into
masterfrom
vNext/support-convenience-testing-in-visual-studio

Conversation

@gimlichael

Copy link
Copy Markdown
Member

This pull request makes the MTP package-validation tests use a package that is prepared automatically for each build, instead of one that developers must pack by hand. Local runs and CI each resolve the package that was actually prepared for them, and stale packages no longer affect local validation.

Validation package preparation:

  • Local builds of the validation test project pack Codebelt.Coverlet.MTP after each real framework build, including builds started from the IDE, and skip design-time builds.
  • Each configuration and target framework gets an isolated output directory, so packages from one build cannot be picked up by another.
  • GitHub Actions disables automatic packing and consumes the downloaded release package, and PrepareValidationPackage=false lets developers validate an existing package outside CI.

Validation test infrastructure:

  • Tests read the package directory from MSBuild metadata rather than a hard-coded artifacts/package path.
  • Missing or ambiguous package errors now direct developers to rebuild the validation test project, replacing the outdated dotnet pack instructions.

Documentation:

  • The contributing guide explains that local builds pack the package automatically, how CI differs, and how to opt out.

The validation tests consumed a package that developers had to pack by hand, and stale packages could silently be used. The project now packs Codebelt.Coverlet.MTP into an isolated per-configuration and per-framework directory after each real build, while CI keeps consuming the downloaded release package.
The tests hard-coded artifacts/package and asked developers to run dotnet pack, which no longer matches how the package is prepared. They now read the package directory from MSBuild metadata, so local runs and CI each resolve the package that was actually prepared for them.
The contributing guide told developers to run dotnet pack before the validation tests, which is no longer required. It now explains that local builds pack the package automatically, that CI uses the downloaded release package, and how to opt out.
@gimlichael gimlichael self-assigned this Oct 20, 2026
@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge, with one non-blocking broken link in the release notes.

Fix All in CodexFindings

  1. P2 Release heading is not clickable ▶
Fix with agent prompt
### Issue 1
CHANGELOG.md:114
The new `[vNext]` heading has no matching link definition because this definition uses `[10.1.2]`. Readers cannot follow the heading to the release comparison. Rename the definition to `[vNext]`.

```suggestion
[vNext]: https://github.com/codebeltnet/coverlet/compare/v10.1.1...vNext
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Local validation builds now prepare an isolated Codebelt.Coverlet.MTP package, while GitHub Actions and opted-out builds use an existing package.

  • Local validation builds prepare the package that MTP tests use.

Reviews (3) · Last reviewed commit: "changelog" · Reviewed by Greptile

aicia-bot and others added 2 commits October 20, 2026 22:17
The validation tests reported a missing Codebelt.Coverlet.MTP package with only a rebuild hint. The messages now name the existing package and the -p:PrepareValidationPackage=true option so developers know how to supply or prepare it.
@gimlichael
gimlichael merged commit d48612f into master Oct 30, 2026
@gimlichael
gimlichael deleted the vNext/support-convenience-testing-in-visual-studio branch October 30, 2026 07:24
Comment thread CHANGELOG.md
- .vscode/settings.json configuration,
- .devcontainer legacy configuration.

[10.1.2]: https://github.com/codebeltnet/coverlet/compare/v10.1.1...vNext

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Release heading is not clickable

The new [vNext] heading has no matching link definition because this definition uses [10.1.2]. Readers cannot follow the heading to the release comparison. Rename the definition to [vNext].

Suggested change
[10.1.2]: https://github.com/codebeltnet/coverlet/compare/v10.1.1...vNext
[vNext]: https://github.com/codebeltnet/coverlet/compare/v10.1.1...vNext
Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 114

Comment:
**Release heading is not clickable**

The new `[vNext]` heading has no matching link definition because this definition uses `[10.1.2]`. Readers cannot follow the heading to the release comparison. Rename the definition to `[vNext]`.

```suggestion
[vNext]: https://github.com/codebeltnet/coverlet/compare/v10.1.1...vNext
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants