Repository navigation
VNext/support convenience testing in visual studio - #5
Merged
gimlichael merged 5 commits intoOct 30, 2026
Merged
Conversation
The validation tests consumed a package that developers had to pack by hand, and stale packages could silently be used. The project now packs Codebelt.Coverlet.MTP into an isolated per-configuration and per-framework directory after each real build, while CI keeps consuming the downloaded release package.
The tests hard-coded artifacts/package and asked developers to run dotnet pack, which no longer matches how the package is prepared. They now read the package directory from MSBuild metadata, so local runs and CI each resolve the package that was actually prepared for them.
The contributing guide told developers to run dotnet pack before the validation tests, which is no longer required. It now explains that local builds pack the package automatically, that CI uses the downloaded release package, and how to opt out.
[Low impact] The PR appears safe to merge, with one non-blocking broken link in the release notes.
|
The validation tests reported a missing Codebelt.Coverlet.MTP package with only a rebuild hint. The messages now name the existing package and the -p:PrepareValidationPackage=true option so developers know how to supply or prepare it.
gimlichael
deleted the
vNext/support-convenience-testing-in-visual-studio
branch
October 30, 2026 07:24
| - .vscode/settings.json configuration, | ||
| - .devcontainer legacy configuration. | ||
|
|
||
| [10.1.2]: https://github.com/codebeltnet/coverlet/compare/v10.1.1...vNext |
There was a problem hiding this comment.
Release heading is not clickable
The new [vNext] heading has no matching link definition because this definition uses [10.1.2]. Readers cannot follow the heading to the release comparison. Rename the definition to [vNext].
Suggested change
| [10.1.2]: https://github.com/codebeltnet/coverlet/compare/v10.1.1...vNext | |
| [vNext]: https://github.com/codebeltnet/coverlet/compare/v10.1.1...vNext |
Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 114
Comment:
**Release heading is not clickable**
The new `[vNext]` heading has no matching link definition because this definition uses `[10.1.2]`. Readers cannot follow the heading to the release comparison. Rename the definition to `[vNext]`.
```suggestion
[vNext]: https://github.com/codebeltnet/coverlet/compare/v10.1.1...vNext
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes the MTP package-validation tests use a package that is prepared automatically for each build, instead of one that developers must pack by hand. Local runs and CI each resolve the package that was actually prepared for them, and stale packages no longer affect local validation.
Validation package preparation:
Codebelt.Coverlet.MTPafter each real framework build, including builds started from the IDE, and skip design-time builds.PrepareValidationPackage=falselets developers validate an existing package outside CI.Validation test infrastructure:
artifacts/packagepath.dotnet packinstructions.Documentation: