chore: drop member_type from MemberEmailDelivery ignored_columns - #2830
Merged
Conversation
mroderick
marked this pull request as ready for review
August 31, 2026 09:58
olleolleolle
approved these changes
Aug 31, 2026
olleolleolle
left a comment
olleolleolle
left a comment
Collaborator
There was a problem hiding this comment.
When we can, we can merge this.
The guard is unnecessary: the column removal ships in the same release as the migration, and no code ever referenced member_type, so stale schema caches on old dynos cannot generate SQL mentioning it. The can_log_in precedent kept its line because that rollout was two-phase; this one is not.
mroderick
force-pushed
the
chore/drop-member-type-ignored-columns
branch
from
August 31, 2026 10:22
7d11214 to
8401c98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #2829: the
ignored_columns += ['member_type']guard added there is unnecessary and would linger as a "why is this here?" artifact.Reasoning
ignored_columnsmatters for two-phase column removals: deploy code that ignores the column first, drop it later, so old dynos with a stale schema cache can't generate SQL referencing it. That is why thecan_log_inprecedent kept its line — its rollout was two-phase.Here the column removal ships in the same release as the migration, and no code ever referenced
member_type(the concern'sINSERTs list explicit attributes; all reads areSELECT .*). Old dynos during the rolling deploy cannot generate SQL mentioning the column, so there is nothing for the guard to protect.Context
Stacked on #2829 — base branch is
chore/remove-unused-member-type; retarget tomasterwhen that merges.