refactor: remove manual group creation UI - #2826
Merged
olleolleolle merged 1 commit intoAug 30, 2026
Merged
Conversation
Now that every chapter gets its Students and Coaches groups automatically on creation, the manual group creation flow is dead code (follow-up to #2823). - Remove Admin::GroupsController#new/#create and the new.html.haml view (also drops the last Chosen-enhanced admin <select>) - Remove the "New group" link from the admin menu - Remove the new/create group routes, plus the already-stale index route (the controller has no index action) - Remove GroupPolicy#create? and its spec coverage - Remove the admin group creation feature spec Kept: the group show page (members, eligible count, subscriptions). Deferring the chapter_with_groups fabricator fold into the base chapter fabricator - it touches ~63 Fabricate(:chapter) call sites and belongs in its own cleanup. Stacked on feature/auto-create-groups-on-chapter-creation (PR #2824).
mroderick
marked this pull request as ready for review
August 30, 2026 18:49
olleolleolle
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up to #2823 / PR #2824. With chapters now auto-creating their Students and Coaches groups on creation, the manual group creation flow is dead code.
Changes
Admin::GroupsController#new/#createandapp/views/admin/groups/new.html.haml(also drops the last Chosen-enhanced admin<select>)indexroute (the controller has no index action)GroupPolicy#create?and its spec coverageWhat stays
Groupmodel and all its scopes — still the core entity for subscriptions and invitationsDeferred
chapter_with_groupsfabricator into the basechapterfabricator — it touches ~63Fabricate(:chapter)call sites across the spec suite and belongs in its own cleanup PR.Testing
spec/features/admin/— 114 examples, 0 failuresStacked PR
Stacked on
feature/auto-create-groups-on-chapter-creation(PR #2824). Once #2824 merges, this PR will retarget tomasterautomatically.Closes #2823