Skip to content

Keep HA protection until onboarded hosts are drained - #367

Merged
fwiesel merged 1 commit into
mainfrom
preserve-successful-onboarding
Oct 16, 2026
Merged

fwiesel merged 1 commit into
mainfrom
preserve-successful-onboarding

Conversation

@fwiesel

@fwiesel fwiesel commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

The Aborted reason makes Instance HA disable protection while instances can still run. Keep Succeeded so HA waits until the host is empty.

Disabling lifecycle management does not erase successful onboarding. Incomplete onboarding still aborts and deletes test instances. Existing Aborted conditions remain unchanged.

All repository tests and pre-commit checks passed.

Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
@fwiesel
fwiesel marked this pull request as ready for review October 15, 2026 09:29
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 74.60% (+1.77%) 👍
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/ready 71.93% (ø)
Coverage details

Compared to commit bc45891 (run #38440638287)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller.go 61.45% (+6.39%) 249 (+2) 153 (+17) 96 (-15) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/offboarding_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/ready/controller_test.go

@fwiesel
fwiesel merged commit 0fc6fc2 into main Oct 16, 2026
7 checks passed
@fwiesel
fwiesel deleted the preserve-successful-onboarding branch October 16, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants