Repository navigation
Conversation
…set to 0 Signed-off-by: morphes1995 <morphes1995@gmail.com> (cherry picked from commit 91e9f00) Conflicts: The cherry-pick was done by resolving minor conflicts. The conflicts appear because ceph@dae572d has not been backported to `squid`. src/rgw/rgw_ratelimit.h - should_rate_limit_list() and should_rate_limit_delete(): do not apply their guards, because the functions do not exist (added by dae572d). - should_rate_limit_read() and should_rate_limit_write(): apply the `if (read_ops() > 0)` / `if (write_ops() > 0)` guard, but keep the `return 0` of the int64_t instead of `return false` (3dae903). src/test/rgw/test_rgw_ratelimit.cc - Do not apply LIST and DELETE tests (added by dae572d). - unlimited_access_not_left_large_read_ops_budget and unlimited_access_not_left_large_write_ops_budget: take the tests, but adapt them to this branch: - RateLimiter ratelimit: drop the g_ceph_context argument (added by dae572d). - should_rate_limit(): drop the trailing "" resource argument (added by dae572d). - bool success / EXPECT_EQ(false, success): int64_t delay / EXPECT_EQ(0, delay) (3dae903).
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…set to 0
Signed-off-by: morphes1995 morphes1995@gmail.com
(cherry picked from commit 91e9f00)
Conflicts:
The cherry-pick was done by resolving minor conflicts. The conflicts appear because
ceph@dae572d has not been backported to
squid.should_rate_limit_list() and should_rate_limit_delete(): do not apply their guards, because the functions do not exist (added by dae572d).
should_rate_limit_read() and should_rate_limit_write(): apply the
if (read_ops() > 0)/if (write_ops() > 0)guard, but keep thereturn 0of the int64_t instead ofreturn false(3dae903).src/test/rgw/test_rgw_ratelimit.cc
Do not apply LIST and DELETE tests (added by dae572d).
unlimited_access_not_left_large_read_ops_budget and unlimited_access_not_left_large_write_ops_budget: take the tests, but adapt them to this branch:
Closes cobaltcore-dev/cloud-storage#602
Backport file
release-management/backports/<uuid>.mdadded (or updated) by this PRidin frontmatter matches the filename stemprovenance.upstream_prsset (orprovenance.type: otherwith another:block)Stage-B risk (filled per
release-management/backports/RISK-RUBRIC.md)blast— cosmetic / availability / data-lossconflict— clean / trivial / substantivecoverage— strong / partial / weakhighband)Merge
Land this via
just merge-backport PR=<N>— do not click the green merge button.The just recipe constructs the merge commit's
Backport-Idtrailer.