Repository navigation
Conversation
shikanime
force-pushed
the
chore/playwright-style-uniformization
branch
from
October 28, 2026 15:52
53a9ae0 to
f66896a
Compare
shikanime
marked this pull request as ready for review
October 28, 2026 15:54
StephaneTrebel
previously approved these changes
Nov 1, 2026
StephaneTrebel
left a comment
StephaneTrebel
left a comment
Collaborator
There was a problem hiding this comment.
No findings. Diff complet relu : normalisation des titres/imports/commentaires et remontée des tags, sans modification fonctionnelle relevée. La collecte reste à 192 tests/24 fichiers et les 192 sélections sont identiques à #2943 après normalisation de la casse et des numéros de ligne ; CI verte, parcours navigateur non réexécutés.
shikanime
force-pushed
the
chore/playwright-style-uniformization
branch
from
November 2, 2026 15:44
f66896a to
f2db239
Compare
shikanime
enabled stacked auto-merge
November 2, 2026 15:50
- Tag @e2e hoisted to describe level in 11 files (clusters, dashboard, keycloak, profile, project-logs, projects, repos, roles, service-chains, tokens, zones); extra tags (@repos, @Integ, @need-rework, @service-chains) stay per-test. Selection verified identical via playwright test --list --grep @e2e before and after. - Test titles normalized to lowercase 'should ...' per the Playwright docs convention (97 renames), including integration-tests. - Imports normalized to relative paths (../config, ../helpers) in admin-users, roles, project-roles. - AAA phase comments (// Arrange, // Act, // Assert) added where the test has a linear three-phase structure; legacy // Create // Validate vocabulary renamed to AAA; verify-as-you-go tests left untouched rather than retro-fitting false boundaries. - profile.spec.ts: expect(locator) result captured in a variable replaced by the standard expect(locator).toContainText pattern. Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Iee4cfa8174c597492134df57ef61333a6a6a6964
shikanime
force-pushed
the
chore/playwright-style-uniformization
branch
from
November 2, 2026 16:07
f2db239 to
e203212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pourquoi
Le style déclaratif des specs e2e divergeait selon les fichiers : tag
@e2eporté tantôt par ledescribe, tantôt test par test, titres enshould/Shouldmélangés, imports en alias (config/,helpers/) dans trois fichiers là où les vingt autres utilisent le relatif, commentaires de phases AAA présents dans certains fichiers et absents ailleurs. La PR #2943 introduit sept nouveaux specs dans le style maison ; cette PR aligne les seize fichiers restants sur ce même style pour que la suite soit homogène.Quoi
@e2eremonté au niveau dudescribedans 11 fichiers (clusters, dashboard, keycloak, profile, project-logs, projects, repos, roles, service-chains, tokens, zones) ; les tags additionnels (@repos,@integ,@need-rework,@service-chains) restent portés par les tests concernés.should ...minuscule, conformément à la convention de la documentation Playwright (96 renoms, suite e2e et integration-tests).../config,../helpers) dans admin-users, roles, project-roles.// Create/// Validaterenommé en AAA ; les tests verify-as-you-go restent sans découpage forcé.profile.spec.ts: capture du résultat deexpect()dans une variable remplacée par le pattern standardawait expect(locator).toContainText.Vérification
pnpm --dir playwright exec playwright test --list --grep @e2eavant (sur e723868) et après (sur 53a9ae0) — mêmes 96 tests, mêmes 192 exécutions navigateur, 24 fichiers ;diffdes deux listings vide après normalisation casse/ligne.pnpm exec eslint e2e-tests/: exit 0.tsc --noEmit -p playwright/tsconfig.json: strictement les mêmes 2 erreurs que sur le commit parent e723868 (module@cpn-console/sharednon construit dans le checkout local,RegExp.escapenon typé) — aucune erreur nouvelle introduite.--grep @e2e, shards) est inchangée.Références