Repository navigation
Conversation
* Test input stream with multiple chunks * Handle encoding when using `SAXParser` as an `UnderlyingSink` * Not all types are processed * Add parsing of `ReadableStream<string>` * Polishing
* Add test to make sure entities are decoded * Test if numeric entities are decoded * Decode numeric entities
Currently they are left unchanged. Other options are possible, like throwing an error or somehow calling a user supplied function to resolve the entities, but for now keep it as is.
* Test for recursive decoding of entities * Don't decode entities recursively
* Add functions to collect raw stream data on demand Can be used to implement something like `innerHtml()` * Add test for input collection * Move input collection to parser state * Add tests for input collection over multiple chunks * Simplify input collection * Use a class for collection tokens instead of a plain number * On collection result emit an `inner_xml` event * Fox indentation * More systematic test cases for innerXML * Renaming * Directly extract proper innerXML in context function * Add comment for future improvements * Some cleanup * Better order of classes
* Preserve white space in text The XML spec says that white space should be preserved and losing white space can be problematic especially in mixed content nodes, like for example `<span><i>some</i> <b>text</b></span>`. If more flexibility in white space handling is desired, one possibility would be to add a config option to the parser that selects the desired white space mode. * Add test for white space handling
If there is another tag directly after the closing tag, we currently don't strip the closing tag.
sth
marked this pull request as draft
July 29, 2026 22:20
Contributor
Author
|
Sorry, I didn't mean open this pull request here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this case the closing tag is currently not recognized correctly and not removed from the captured xml fragment.